Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpUnit: remove dynamic calls to static methods #37

Conversation

JoolsMcFly
Copy link
Contributor

Hi.

Instead of adding exceptions in PHPStan we can just replace dynamic calls with their static counterparts.

@JoolsMcFly
Copy link
Contributor Author

Not sure what I should do about Scrutinizer related issues...

@JoolsMcFly JoolsMcFly force-pushed the chore/remove-dynamic-calls-to-static-methods branch 2 times, most recently from 6c20ed3 to 89964d0 Compare October 12, 2024 16:47
@JoolsMcFly JoolsMcFly force-pushed the chore/remove-dynamic-calls-to-static-methods branch from 89964d0 to 645823c Compare October 12, 2024 16:49
@JoolsMcFly
Copy link
Contributor Author

JoolsMcFly commented Oct 12, 2024

🤔 I signed my commit, local git log shows that's it's been Signed-off-by, I force pushed but it won't show as signed here or in my other PR.

Any idea?

@MauricioFauth MauricioFauth self-assigned this Oct 12, 2024
@MauricioFauth MauricioFauth added this to the 4.0.0 milestone Oct 12, 2024
@MauricioFauth MauricioFauth merged commit 8248afe into phpmyadmin:master Oct 12, 2024
9 checks passed
@JoolsMcFly JoolsMcFly deleted the chore/remove-dynamic-calls-to-static-methods branch October 13, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants